ESQL: Remove extra block calls in evaluators and aggregators #135919
+4,127
−3,954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>non-issue
Team:Analytics
ivancea
commented
Oct 3, 2025
Comment on lines
157
to
158
| builder.addCode("case 1:\n"); | ||
| builder.addStatement("break"); |
There was a problem hiding this comment.
This looks a bit weird, but I'm not sure if this is better than a variable + 2 ifs, like:
if (count == 0) { null + continue }
else if (count > 1) { warning + null + continue }
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
reviewed
Oct 3, 2025
| private void addRawBlock(LongBlock vBlock) { | ||
| for (int p = 0; p < vBlock.getPositionCount(); p++) { | ||
| if (vBlock.isNull(p)) { | ||
| int vValueValueCount = vBlock.getValueCount(p); |
There was a problem hiding this comment.
vValueValueCount -> vValueCount probably.
| if (valBlock.isNull(p)) { | ||
| switch (valBlock.getValueCount(p)) { | ||
| case 0: | ||
| result.appendNull(); |
There was a problem hiding this comment.
Sure. I thought it was correct because spotless didn't change it. Only to remember now that spotless ignore these files :hehe:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 implementers changed:
isNull() + getValueCount()to a singlegetValueCount().getValueCount()delegates toisNull()internally for Array blocks, and they're supposed to be in sync.getValueCount() == 0after theisNull() == false)These changes were made to:
isNull()to agetValueCount()delegating toisNull()in some casesisNull() + getValueCount()by removing theisNull(), which could access aBitSetAggs microbenchmarks show no differences.