Increase bound in IrateTests matcher to 3000.0 to fix flaky assertion… #135935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
elasticsearchmachine
added
v9.3.0
needs:triage
0xShubhamSolanki
force-pushed
the
fix-irate-test-bound
branch
from
664e576 to
aae5516
Compare
elasticsearchmachine
added
Team:StorageEngine
and removed
needs:triage
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the matcher bound factor from 2000.0 to 3000.0 in IrateTests.makeSupplier to handle larger rates in big positive doubles cases.
Fixes #135757
Tested locally with the reproduction command—passes consistently.