Split on line feed when parsing transport files in the build #135978
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
Oct 3, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 3, 2025
…#135978) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
This was referenced Oct 3, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 3, 2025
…#135978) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 3, 2025
…#135978) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 3, 2025
…#135978) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2025
#135983) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2025
#135984) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
rjernst
added a commit
that referenced
this pull request
Oct 4, 2025
#135985) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
rjernst
added a commit
that referenced
this pull request
Oct 4, 2025
#135982) When parsing transport files that may contain comments we split on newline. On windows systems these files _might_ have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing transport files that may contain comments we split on newline. On windows systems these files might have the line feed replaced by CRLF. This commit adjusts the parsing to only split on line feed so that regardless of what the system line separator is we will split the lines as needed.