-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Allow allocating clones over low watermark #137399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DaveCTurner
merged 3 commits into
elastic:main
from
DaveCTurner:2025/10/30/allocate-clone-over-low-watermark
Oct 31, 2025
Merged
Allow allocating clones over low watermark #137399
DaveCTurner
merged 3 commits into
elastic:main
from
DaveCTurner:2025/10/30/allocate-clone-over-low-watermark
Oct 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new shard which is the result of a clone operation starts out on the same node as the shard being cloned and takes no additional space due to hard-linking, so we can safely allocate it even if the node is over the low watermark, and skip the checks that consider the additional space taken by the shard. Closes ES-13384
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 31, 2025
A new shard which is the result of a clone operation starts out on the same node as the shard being cloned and takes no additional space due to hard-linking, so we can safely allocate it even if the node is over the low watermark, and skip the checks that consider the additional space taken by the shard. Closes ES-13384
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 31, 2025
A new shard which is the result of a clone operation starts out on the same node as the shard being cloned and takes no additional space due to hard-linking, so we can safely allocate it even if the node is over the low watermark, and skip the checks that consider the additional space taken by the shard. Closes ES-13384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:Distributed Coordination/Allocation
All issues relating to the decision making around placing a shard (both master logic & on the nodes)
Team:Distributed Coordination
Meta label for Distributed Coordination team
v9.2.1
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new shard which is the result of a clone operation starts out on the
same node as the shard being cloned and takes no additional space due to
hard-linking, so we can safely allocate it even if the node is over the
low watermark, and skip the checks that consider the additional space
taken by the shard.
Closes ES-13384