Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Jan 25, 2025

What is the problem this PR solves?

Bump versions for the updatecli and enable dependabot.

Let's try to fix the existing issue with #4353 (comment)

How to test this PR locally

I created https://github.com/v1v/fleet-server/pull/9 using my fork and local changes

$ GIT_USER=v1v GIT_EMAIL=v1v@v1v.com GITHUB_TOKEN=$(gh auth token) updatecli apply --config .ci/bump-golang.yml

How to test this PR in the CI

see https://github.com/elastic/fleet-server/actions/runs/12965426929 and https://github.com/elastic/fleet-server/actions/runs/12965447758

I can see https://github.com/elastic/fleet-server/pull/4323/commits hence it's much better now, or at least, I can see it didn't close it with a force push.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 25, 2025
@v1v v1v marked this pull request as ready for review January 27, 2025 21:03
@v1v v1v requested a review from a team as a code owner January 27, 2025 21:03
@v1v v1v enabled auto-merge (squash) January 28, 2025 16:33
@v1v v1v disabled auto-merge February 6, 2025 18:35
@v1v v1v merged commit 33cbb96 into main Feb 6, 2025
7 checks passed
@v1v v1v deleted the feature/bump-updatecli branch February 6, 2025 18:35
mergify bot pushed a commit that referenced this pull request Feb 6, 2025
v1v added a commit that referenced this pull request Feb 11, 2025
(cherry picked from commit 33cbb96)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants