-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetest OTEL] Follow up enhancements #11310
[Kubernetest OTEL] Follow up enhancements #11310
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Hey @ChrsMark in this PR I think I've addressed your comments you've left in #10910 (review), mainly in the second commit - 071f1ef
to double-check: is this comment already updated? Now there is used both:
done |
Just a reminder to update the id of the dashborad : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank's for addressing the comments!
LGTM
"params": { | ||
"format": { | ||
"id": "percent", | ||
"params": { | ||
"decimals": 2 | ||
} | ||
}, | ||
"formula": "last_value(metrics.k8s.node.cpu.usage)/last_value(metrics.k8s.node.allocatable_cpu)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI there is a plan to add back the k8s.node.cpu.utilization
but it will take some time since it's happening through a deprecation process which will take a while. In that case the k8s.node.cpu.utilization
will be a ratio against the Node's capacity not the Node's allocatable cpu (capacity>allocatable), but it can be decided later if it will be fine to switch to that metric directly or not.
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Note: the name of the dashboard must follow this pattern: https://github.com/elastic/package-spec/blob/v3.2.2/spec/content/kibana/spec.yml#L12, so renamed to |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
|
Package kubernetes_otel - 0.0.2 containing this change is available at https://epr.elastic.co/search?package=kubernetes_otel |
Proposed commit message
Please explain:
data_stream.dataset: *.otel
, usemetrics-*otel*
for adhoc dataviews, for events uselogs-*otel*
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots