-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws] Bump package-spec version to 3.3.1 #11893
Open
zmoog
wants to merge
5
commits into
elastic:main
Choose a base branch
from
zmoog:zmoog/aws-package-spec-3.3.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -430,4 +430,4 @@ | |
] | ||
} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,13 +77,27 @@ Please refer to the following [document](https://www.elastic.co/guide/en/ecs/cur | |
| aws.s3.object.key | The AWS S3 Object key. | keyword | | ||
| aws.waf.arn | AWS ARN of ACL | keyword | | ||
| aws.waf.id | ID of ACL | keyword | | ||
| aws.waf.non_terminating_matching_rules | The list of non-terminating rules in the rule group that match the request. These are always COUNT rules (non-terminating rules that match) | nested | | ||
| aws.waf.non_terminating_matching_rules.action | | keyword | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it is a public documentation - we shouldn't leave those fields without description wondering if it is maybe better to split version bump and waf PRs |
||
| aws.waf.non_terminating_matching_rules.ruleId | | keyword | | ||
| aws.waf.non_terminating_matching_rules.ruleMatchDetails.conditionType | | keyword | | ||
| aws.waf.non_terminating_matching_rules.ruleMatchDetails.location | | keyword | | ||
| aws.waf.non_terminating_matching_rules.ruleMatchDetails.matchedData | | keyword | | ||
| aws.waf.rate_based_rule_list | The list of rate-based rules that acted on the request. | nested | | ||
| aws.waf.request.headers | List of request headers | flattened | | ||
| aws.waf.rule_group_list | The list of rule groups that acted on this request. | nested | | ||
| aws.waf.rule_group_list.nonTerminatingMatchingRules.action | | keyword | | ||
| aws.waf.rule_group_list.nonTerminatingMatchingRules.ruleId | | keyword | | ||
| aws.waf.rule_group_list.nonTerminatingMatchingRules.ruleMatchDetails.conditionType | | keyword | | ||
| aws.waf.rule_group_list.nonTerminatingMatchingRules.ruleMatchDetails.location | | keyword | | ||
| aws.waf.rule_group_list.nonTerminatingMatchingRules.ruleMatchDetails.matchedData | | keyword | | ||
| aws.waf.rule_group_list.ruleGroupId | | keyword | | ||
| aws.waf.rule_group_list.terminatingRule.action | | keyword | | ||
| aws.waf.rule_group_list.terminatingRule.ruleId | | keyword | | ||
| aws.waf.source.id | The source ID. This field shows the ID of the associated resource. | keyword | | ||
| aws.waf.source.name | The source of the request. Possible values: CF for Amazon CloudFront, APIGW for Amazon API Gateway, ALB for Application Load Balancer, and APPSYNC for AWS AppSync. | keyword | | ||
| aws.waf.terminating_rule_match_details | Detailed information about the terminating rule that matched the request. A terminating rule has an action that ends the inspection process against a web request. Possible actions for a terminating rule are ALLOW and BLOCK. This is only populated for SQL injection and cross-site scripting (XSS) match rule statements. As with all rule statements that inspect for more than one thing, AWS WAF applies the action on the first match and stops inspecting the web request. A web request with a terminating action could contain other threats, in addition to the one reported in the log. | nested | | ||
| aws.waf.terminating_rule_match_details.conditionType | | keyword | | ||
| aws.waf.terminating_rule_match_details.location | | keyword | | ||
| aws.waf.terminating_rule_match_details.matchedData | | keyword | | ||
| cloud.image.id | Image ID for the cloud instance. | keyword | | ||
| data_stream.dataset | Data stream dataset. | constant_keyword | | ||
| data_stream.namespace | Data stream namespace. | constant_keyword | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
format_version: 3.0.0 | ||
format_version: 3.3.1 | ||
name: aws | ||
title: AWS | ||
version: 2.36.2 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic of the
rename
processor above and the addedremove
processor is not straightforward to read. It looks like they may influence each other (but they don't):Rename
message
toevent.original
(if we only havemessage
).Remove
message
(if we have bothmessage
andevent.original
, which is only true if both were present in the pipeline input).I think it's slightly better if the
remove
is before therename
:Remove
message
(if we have bothmessage
andevent.original
)Rename
message
toevent.original
(if we only havemessage
)