Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update teams permissions in pull request pipeline #13016

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Mar 7, 2025

Proposed commit message

Update team permissions related to Pull Request pipeline in catalog-info.yaml.

Teams added in this PR are the ones found in .github/CODEOWNERS file. These are the teams:

@elastic/cloud-security-posture
@elastic/customer-architects
@elastic/ecosystem
@elastic/elastic-agent
@elastic/elastic-agent-data-plane
@elastic/fleet
@elastic/logstash
@elastic/ml-ui
@elastic/obs-ds-hosted-services
@elastic/obs-ds-intake-services
@elastic/obs-infraobs-integrations
@elastic/obs-ux-management-team
@elastic/profiling
@elastic/protections
@elastic/search-extract-and-transform
@elastic/sec-applied-ml
@elastic/sec-deployment-and-devices
@elastic/sec-linux-platform
@elastic/security-asset-management
@elastic/security-service-integrations
@elastic/sec-windows-platform
@elastic/stack-monitoring

@mrodm mrodm self-assigned this Mar 7, 2025
@elasticmachine
Copy link

elasticmachine commented Mar 7, 2025

💔 Build Failed

Failed CI Steps

History

cc @mrodm

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mrodm mrodm marked this pull request as ready for review March 7, 2025 16:21
@mrodm mrodm requested a review from a team as a code owner March 7, 2025 16:21
@mrodm mrodm requested a review from v1v March 7, 2025 16:21
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mario!

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Would it be possible to expand the codeowners scripts so this file is updated automatically too? No need to do it now, we can do it later.

@v1v v1v changed the title [CI] Update teams permissions in pull rqeuest pipeline [CI] Update teams permissions in pull request pipeline Mar 10, 2025
@mrodm
Copy link
Contributor Author

mrodm commented Mar 10, 2025

Would it be possible to expand the codeowners scripts so this file is updated automatically too? No need to do it now, we can do it later.

I guess, it could be updated the logic in dev/codeowners/codeowners.go to warn if the configuration of that pipeline does not contain some team (codeowner).

Another option could be to run some script via updatecli as it is done to update the templates for issues here:

The concern is that catalog-info.yml contain multiple YAML documents and I don't know how easy or difficult it would be to update it automatically.

@mrodm mrodm merged commit 1cce1a9 into elastic:main Mar 10, 2025
6 of 7 checks passed
@mrodm mrodm deleted the update_permissions_pr_pipeline branch March 10, 2025 17:19
@mrodm
Copy link
Contributor Author

mrodm commented Mar 10, 2025

Created a new issue for that automation process: #13047
cc @jsoriano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants