Aligned data pulls to calendar days #13020
Merged
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
History
|
|
|
Package ess_billing - 1.3.0 containing this change is available at https://epr.elastic.co/package/ess_billing/1.3.0/ |
andrewkroh
added
the
Integration:ess_billing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation of the integration, the billing data was pulled with an offset starting when the integration is first run. This had the side effect of aligning days to whatever current time it was at installation.
IE instead of pulling from 00:00 to 23:59, it could be from 11:00 to 10:59 for instance.
This fixes this behavior, while also changing the lookbehind behavior: it used to be a count of hours, whereas it is now a count of days.