Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_workspace: fix JSON error and login challenge_status handling #13070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 12, 2025

Proposed commit message

google_workspace: fix JSON error and login challenge_status handling

Also improve error reporting for cases where JSON parsing cannot be
successfully carried out. Previously JSON parsing failures would be
silently ignored leaving no indication that that was the cause of a
document not being processed correctly. With the changes here, failing
to parse the JSON results in pipeline termination with an informative
message since no furthe work can be done without the parsed JSON.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:google_workspace Google Workspace bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Mar 12, 2025
@efd6 efd6 self-assigned this Mar 12, 2025
Also improve error reporting for cases where JSON parsing cannot be
successfully carried out. Previously JSON parsing failures would be
silently ignored leaving no indication that that was the cause of a
document not being processed correctly. With the changes here, failing
to parse the JSON results in pipeline termination with an informative
message since no furthe work can be done without the parsed JSON.
@efd6 efd6 force-pushed the 12976-google_workspace branch from 6dbe15c to 2e009a9 Compare March 12, 2025 03:28
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
5.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review March 12, 2025 05:25
@efd6 efd6 requested a review from a team as a code owner March 12, 2025 05:25
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:google_workspace Google Workspace Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Google Workspace]: Misclassification of Successful Logins with "Challenge Passed" Status
2 participants