-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream #7155
[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream #7155
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
🌐 Coverage report
|
@tetianakravchenko I see #7162 it is the tracking issue for the Do you see this problem as a blocker for this PR? |
Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions? |
There is no such information available in this datastream, here is the list of metrics - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics as you see those metrics are on the registry level, not for each specific image |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
/test |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Package azure_metrics - 1.0.22 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
- name: agent_pool_cpu_time.total | ||
type: float | ||
metric_type: gauge | ||
unis: s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "unis" should be "unit".
What does this PR do?
remove duplicated fields
instead of using wildcard in the field name - use predefined field names
used fields for dimensions:
cloud.region
azure.resource.id
- this field includes azure.subscription_id, azure.resource.group, azure.resource.name, format:azure.timegrain
metrics - use predefined metrics - since in the configuration is defined list of metrics
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots