Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure][Container_registry] Add dimension and metric_type metadata to the container_registry datastream #7155

Merged

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Jul 26, 2023

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jul 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T15:55:32.112+0000

  • Duration: 14 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👍
Lines 100.0% (21/21) 💚
Conditionals 100.0% (0/0) 💚

@zmoog
Copy link
Contributor

zmoog commented Jul 28, 2023

@tetianakravchenko I see #7162 it is the tracking issue for the timegrain problem.

Do you see this problem as a blocker for this PR?

@agithomas
Copy link
Contributor

Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions?

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Aug 1, 2023
@tetianakravchenko
Copy link
Contributor Author

@agithomas

Which field will hold the names of the images, tags, other meta data information ? Shouldn't they be dimensions?

There is no such information available in this datastream, here is the list of metrics - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics

as you see those metrics are on the registry level, not for each specific image

all available fields:
Screenshot 2023-08-02 at 12 41 53

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Contributor Author

/test

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko merged commit 0cd1a8e into elastic:main Aug 16, 2023
@tetianakravchenko tetianakravchenko deleted the azure-container-registry-tsdb branch August 16, 2023 16:14
@elasticmachine
Copy link

Package azure_metrics - 1.0.22 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

- name: agent_pool_cpu_time.total
type: float
metric_type: gauge
unis: s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "unis" should be "unit".

@andrewkroh andrewkroh added Integration:azure_metrics Azure Resource Metrics and removed Integration:azure Azure Logs labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants