-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add permissions for "input-only" package #166234
[APM] Add permissions for "input-only" package #166234
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/apm-ui (Team:APM) |
Pinging @elastic/fleet (Team:Fleet) |
d59dbdc
to
a626d30
Compare
@@ -49,112 +50,114 @@ export async function storedPackagePoliciesToAgentPermissions( | |||
return; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewer: Remove whitespace to improve readability of this diff: https://github.com/elastic/kibana/pull/166234/files?diff=unified&w=1#r1329801250
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Show resolved
Hide resolved
x-pack/plugins/fleet/server/integration_tests/cloud_preconfiguration.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM changes LGTM 🧑🏫
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet changes LGTM
cba491a
to
80e0fa1
Compare
579c2ce
to
9f8e63d
Compare
9f8e63d
to
0f9f73f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
✅ Test plan 8.11Tested this by applying re-route processors. Namespace re-routing
Traces were re-routed to Dataset re-rerouting
Traces were rerouted to This means that nothing is broken as a result of the input-only packages changes and APM Server is still able to ingest as expected. Whether the new permissions actually work will be tested out in the next release when APM Server starts taking advantage of this. |
Closes: #164936
This grants the necessary permissions to APM Server when running under fleet.