[APM\ Update index template names considered in the diagnostics page #184343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
force-pushed
the
184333-diagnostics-page-fix
branch
from
4e24917
to
a8576cb
Compare
crespocarlos
force-pushed
the
184333-diagnostics-page-fix
branch
from
a8576cb
to
bb4e146
Compare
|
/ci |
crespocarlos
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
@elasticmachine merge upstream |
botelastic
bot
added
the
ci:project-deploy-observability
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
…lastic#184343) closes [elastic#184333](elastic#184333) ## Summary This PR updates the index template names that the diagnostics page verifies the existence of. After the changes made in the [APM package](elastic/integrations#9949), to favor APM indices and ingest pipelines configured by elasticsearch, the index templates now have a `@template` suffix. eg: `metrics-apm.service_destination.1m` is now `metrics-apm.service_destination.1m@template` <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/4608da37-679a-411c-85c4-409b2af62cec"> <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/837c8ae0-2c92-4763-811c-22fc619ba5f6"> **When no indices are found** <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/33d7264a-dc90-49a0-a3f4-f169dcbda861"> ### How to test - Start a local ES and kibana instance - navigate to `/apm/diagnostics/index-templates?rangeFrom=now-15m&rangeTo=now` --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #184333
Summary
This PR updates the index template names that the diagnostics page verifies the existence of.
After the changes made in the APM package, to favor APM indices and ingest pipelines configured by elasticsearch, the index templates now have a
@templatesuffix. eg:metrics-apm.service_destination.1mis nowmetrics-apm.service_destination.1m@templateWhen no indices are found
How to test
/apm/diagnostics/index-templates?rangeFrom=now-15m&rangeTo=now