Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Remove preconfigured Agentless policy solution and feature flag #197338

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Cloud Security] Remove preconfigured Agentless policy solution and feature flag #197338

wants to merge 7 commits into from
+87 −589

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Oct 22, 2024 •
edited
Loading

Summary

Remove solution that depended on the preconfigured Agentless policy and Fleet experimental feature agentless, the unit tests that relied on the agentless policy and experimental feature were refactored or removed.

Related Issues

Checklist

@seanrathier seanrathier force-pushed the 10239-debt-remove-the-serverless-default-agentless-policy-solution-from-kibana branch 2 times, most recently from 0ab8a24 to 07ba001 Compare October 23, 2024 18:22
@seanrathier seanrathier self-assigned this Oct 23, 2024
@seanrathier seanrathier added Team:Fleet Team label for Observability Data Collection Fleet team Team:Cloud Security Cloud Security team related release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 23, 2024
@elastic elastic deleted a comment from elasticmachine Oct 23, 2024
@seanrathier seanrathier marked this pull request as ready for review October 24, 2024 13:19
@seanrathier seanrathier requested review from a team as code owners October 24, 2024 13:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@seanrathier seanrathier force-pushed the 10239-debt-remove-the-serverless-default-agentless-policy-solution-from-kibana branch from 8fb6e59 to e45f2be Compare October 24, 2024 13:23
@seanrathier seanrathier added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project labels Oct 24, 2024
juliaElastic
juliaElastic approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanrathier seanrathier added ci:project-redeploy Always create a new Cloud project ci:cloud-redeploy Always create a new Cloud deployment labels Oct 24, 2024
@seanrathier seanrathier force-pushed the 10239-debt-remove-the-serverless-default-agentless-policy-solution-from-kibana branch from 5f29df9 to e393381 Compare October 25, 2024 16:00
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 25, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB -508.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 172.6KB 172.5KB -69.0B

History

cc @seanrathier

@seanrathier seanrathier removed the ci:cloud-redeploy Always create a new Cloud deployment label Oct 25, 2024
@seanrathier seanrathier removed the ci:project-redeploy Always create a new Cloud project label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Omolola-Akinleye Omolola-Akinleye Omolola-Akinleye approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@seanrathier seanrathier

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanrathier @elasticmachine @Omolola-Akinleye @juliaElastic