-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) #197722
Conversation
…ted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (elastic#197156)
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix works as expected, thanks for the improvement!
Starting backport for target branches: 8.16, 8.x |
…ted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (elastic#197156) (elastic#197722) ## Summary Bug elastic#197156 This is a UI part of the bug that warns a user about missing indices used in knowledge base entries. ### To test 1. Add an index entry that uses existing index 2. Remove that index 3. Go back to knowledge base entries page 4. You should see warning icon next to the name of the index entry which uses removed index. Also, when you edit that entry you will see `Index doesn't exist` error next to the `Index` field in the flyout <img width="1458" alt="Screenshot 2024-10-24 at 19 54 36" src="https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220"> <img width="615" alt="Screenshot 2024-10-24 at 19 54 52" src="https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a1d755a)
…ted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (elastic#197156) (elastic#197722) ## Summary Bug elastic#197156 This is a UI part of the bug that warns a user about missing indices used in knowledge base entries. ### To test 1. Add an index entry that uses existing index 2. Remove that index 3. Go back to knowledge base entries page 4. You should see warning icon next to the name of the index entry which uses removed index. Also, when you edit that entry you will see `Index doesn't exist` error next to the `Index` field in the flyout <img width="1458" alt="Screenshot 2024-10-24 at 19 54 36" src="https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220"> <img width="615" alt="Screenshot 2024-10-24 at 19 54 52" src="https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a1d755a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…re deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722) (#197894) # Backport This will backport the following commits from `main` to `8.16`: - [[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)](#197722) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T19:17:57Z","message":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)\n\n## Summary\r\n\r\nBug https://github.com/elastic/kibana/issues/197156\r\n\r\nThis is a UI part of the bug that warns a user about missing indices\r\nused in knowledge base entries.\r\n\r\n### To test\r\n\r\n1. Add an index entry that uses existing index\r\n2. Remove that index\r\n3. Go back to knowledge base entries page\r\n4. You should see warning icon next to the name of the index entry which\r\nuses removed index. Also, when you edit that entry you will see `Index\r\ndoesn't exist` error next to the `Index` field in the flyout\r\n\r\n<img width=\"1458\" alt=\"Screenshot 2024-10-24 at 19 54 36\"\r\nsrc=\"https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220\">\r\n\r\n<img width=\"615\" alt=\"Screenshot 2024-10-24 at 19 54 52\"\r\nsrc=\"https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a1d755a675b05269f167d160f4c0c28a83d5e4d5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.16.0"],"title":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156)","number":197722,"url":"https://github.com/elastic/kibana/pull/197722","mergeCommit":{"message":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)\n\n## Summary\r\n\r\nBug https://github.com/elastic/kibana/issues/197156\r\n\r\nThis is a UI part of the bug that warns a user about missing indices\r\nused in knowledge base entries.\r\n\r\n### To test\r\n\r\n1. Add an index entry that uses existing index\r\n2. Remove that index\r\n3. Go back to knowledge base entries page\r\n4. You should see warning icon next to the name of the index entry which\r\nuses removed index. Also, when you edit that entry you will see `Index\r\ndoesn't exist` error next to the `Index` field in the flyout\r\n\r\n<img width=\"1458\" alt=\"Screenshot 2024-10-24 at 19 54 36\"\r\nsrc=\"https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220\">\r\n\r\n<img width=\"615\" alt=\"Screenshot 2024-10-24 at 19 54 52\"\r\nsrc=\"https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a1d755a675b05269f167d160f4c0c28a83d5e4d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197722","number":197722,"mergeCommit":{"message":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)\n\n## Summary\r\n\r\nBug https://github.com/elastic/kibana/issues/197156\r\n\r\nThis is a UI part of the bug that warns a user about missing indices\r\nused in knowledge base entries.\r\n\r\n### To test\r\n\r\n1. Add an index entry that uses existing index\r\n2. Remove that index\r\n3. Go back to knowledge base entries page\r\n4. You should see warning icon next to the name of the index entry which\r\nuses removed index. Also, when you edit that entry you will see `Index\r\ndoesn't exist` error next to the `Index` field in the flyout\r\n\r\n<img width=\"1458\" alt=\"Screenshot 2024-10-24 at 19 54 36\"\r\nsrc=\"https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220\">\r\n\r\n<img width=\"615\" alt=\"Screenshot 2024-10-24 at 19 54 52\"\r\nsrc=\"https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a1d755a675b05269f167d160f4c0c28a83d5e4d5"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
…e deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722) (#197895) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)](#197722) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T19:17:57Z","message":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)\n\n## Summary\r\n\r\nBug https://github.com/elastic/kibana/issues/197156\r\n\r\nThis is a UI part of the bug that warns a user about missing indices\r\nused in knowledge base entries.\r\n\r\n### To test\r\n\r\n1. Add an index entry that uses existing index\r\n2. Remove that index\r\n3. Go back to knowledge base entries page\r\n4. You should see warning icon next to the name of the index entry which\r\nuses removed index. Also, when you edit that entry you will see `Index\r\ndoesn't exist` error next to the `Index` field in the flyout\r\n\r\n<img width=\"1458\" alt=\"Screenshot 2024-10-24 at 19 54 36\"\r\nsrc=\"https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220\">\r\n\r\n<img width=\"615\" alt=\"Screenshot 2024-10-24 at 19 54 52\"\r\nsrc=\"https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a1d755a675b05269f167d160f4c0c28a83d5e4d5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.16.0"],"title":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156)","number":197722,"url":"https://github.com/elastic/kibana/pull/197722","mergeCommit":{"message":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)\n\n## Summary\r\n\r\nBug https://github.com/elastic/kibana/issues/197156\r\n\r\nThis is a UI part of the bug that warns a user about missing indices\r\nused in knowledge base entries.\r\n\r\n### To test\r\n\r\n1. Add an index entry that uses existing index\r\n2. Remove that index\r\n3. Go back to knowledge base entries page\r\n4. You should see warning icon next to the name of the index entry which\r\nuses removed index. Also, when you edit that entry you will see `Index\r\ndoesn't exist` error next to the `Index` field in the flyout\r\n\r\n<img width=\"1458\" alt=\"Screenshot 2024-10-24 at 19 54 36\"\r\nsrc=\"https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220\">\r\n\r\n<img width=\"615\" alt=\"Screenshot 2024-10-24 at 19 54 52\"\r\nsrc=\"https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a1d755a675b05269f167d160f4c0c28a83d5e4d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197722","number":197722,"mergeCommit":{"message":"[Security GenAI] When indices referenced in KB index entries are deleted from OUTSIDE the AI Assistant KB UI, there is not indication to the user (#197156) (#197722)\n\n## Summary\r\n\r\nBug https://github.com/elastic/kibana/issues/197156\r\n\r\nThis is a UI part of the bug that warns a user about missing indices\r\nused in knowledge base entries.\r\n\r\n### To test\r\n\r\n1. Add an index entry that uses existing index\r\n2. Remove that index\r\n3. Go back to knowledge base entries page\r\n4. You should see warning icon next to the name of the index entry which\r\nuses removed index. Also, when you edit that entry you will see `Index\r\ndoesn't exist` error next to the `Index` field in the flyout\r\n\r\n<img width=\"1458\" alt=\"Screenshot 2024-10-24 at 19 54 36\"\r\nsrc=\"https://github.com/user-attachments/assets/7d4468f9-fada-4416-9480-99bfca3de220\">\r\n\r\n<img width=\"615\" alt=\"Screenshot 2024-10-24 at 19 54 52\"\r\nsrc=\"https://github.com/user-attachments/assets/fd9bbe80-0a3c-40b8-909a-93f8082e69eb\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a1d755a675b05269f167d160f4c0c28a83d5e4d5"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
Summary
Bug #197156
This is a UI part of the bug that warns a user about missing indices used in knowledge base entries.
To test
Index doesn't exist
error next to theIndex
field in the flyoutChecklist
Delete any items that are not applicable to this PR.