-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React@18 failing tests] Dataset quality handles user privileges #197830
Conversation
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing it.
Looks like useObservable
does not treat the initializer arguments as react does with useState
where the initializer argument is ignored after the initial render. docs
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Starting backport for target branches: 8.x |
…stic#197830) (cherry picked from commit 4d36994)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#197830) (#197872) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18 failing tests] Dataset quality handles user privileges (#197830)](#197830) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T16:21:28Z","message":"[React@18 failing tests] Dataset quality handles user privileges (#197830)","sha":"4d369946574bc9f07a5720dde66cfd4719795be6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability"],"title":"[React@18 failing tests] Dataset quality handles user privileges","number":197830,"url":"https://github.com/elastic/kibana/pull/197830","mergeCommit":{"message":"[React@18 failing tests] Dataset quality handles user privileges (#197830)","sha":"4d369946574bc9f07a5720dde66cfd4719795be6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197830","number":197830,"mergeCommit":{"message":"[React@18 failing tests] Dataset quality handles user privileges (#197830)","sha":"4d369946574bc9f07a5720dde66cfd4719795be6"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Summary
Similar to #196384 another test on dataset quality page started failing with React@18.
Looks like the failure is similar as there is inifite re-render now with React@18, but not with React@17. I, unfortunatly, can't explain why it breaks :(