-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Quiet quickcheck i18n output #197871
base: main
Are you sure you want to change the base?
Conversation
…g happens in i18n_check
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]
|
@@ -131,13 +128,15 @@ run( | |||
{ | |||
concurrent: false, | |||
exitOnError: true, | |||
renderer: process.env.CI ? 'verbose' : ('default' as any), | |||
forceTTY: false, | |||
renderer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the silent flag still needed if we just removed verbose logging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to remove non-error logs for CI.
Summary
The i18n check spews out ~5k lines of log. This makes it difficult to spot any errors, or even break the check through some buffer issue.
This PR quiets output from i18n quick check, yet keeping the error outputs.
We've tested it in #194379, and locally (to see if we still see the errors) - it seems to have fixed errors from @pgayvallet 's case.