Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] Data stream resource initialization helper #197893

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Security solution] Data stream resource initialization helper #197893

wants to merge 4 commits into from
+29 −25

Conversation

stephmilovic
Copy link
Contributor

Summary

Fixes a bug with the resource initialization helper by awaiting the getter promise, ensuring resource installation happens once license has updated.

Steps to reproduce

  1. Start es with a basic license
  2. Start kibana
  3. Visit the assistant
  4. Click Manage license. License settings will open in a new tab. Start a trial
  5. Return to the open tab with Assistant

Previous Behavior

Error messages shown for create conversation and update prompt
e2

New Behavior

Conversations and quick prompts are created without issue

Still to do

Need to go through and make dataClient required in our APIs, and add error handling for when it is undefined

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 25, 2024
@stephmilovic stephmilovic requested a review from a team as a code owner October 25, 2024 19:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

stephmilovic
stephmilovic commented Oct 25, 2024
View reviewed changes
...plugins/elastic_assistant/server/ai_assistant_service/create_resource_installation_helper.ts
if (!initializedResources.has(key)) {
return errorResult(`Unrecognized spaceId ${key}`);
}
const initializationState = await initializedResources.get(key);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key fix is adding await here

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 25, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry creating concrete index for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry creating concrete index for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry updating index mappings for existing indices for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry updating index mappings for existing indices for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry updating index settings for existing indices for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry updating index settings for existing indices for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry updating index template for transient ES errors
  • [job] [logs] Jest Tests #5 / AI Assistant Service retries should retry updating index template for transient ES errors

Metrics [docs]

✅ unchanged

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephmilovic @elasticmachine