Skip to content

[Dashboards as Code] Unify Dashboard endpoint status codes with other As Code APIs#258346

Open
nickpeihl wants to merge 5 commits intoelastic:mainfrom
nickpeihl:delete-dash-204
Open

[Dashboards as Code] Unify Dashboard endpoint status codes with other As Code APIs#258346
nickpeihl wants to merge 5 commits intoelastic:mainfrom
nickpeihl:delete-dash-204

Conversation

@nickpeihl
Copy link
Contributor

@nickpeihl nickpeihl commented Mar 18, 2026 •
edited
Loading

Summary

Updates the Dashboard create and delete endpoints to return 201 and 204, respectively on a successful operations. This is in line with our as code API expectations and other API endpoints like Data Views and Lens.

@nickpeihl nickpeihl requested a review from a team as a code owner March 18, 2026 13:06
@nickpeihl nickpeihl added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Dashboards API v9.4.0 labels Mar 18, 2026
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 18, 2026

Pinging @elastic/kibana-presentation (Team:Presentation)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (4)
  • reviewer:coderabbit
  • Team:Search
  • Team:Operations
  • Team:QA

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 43446837-4645-475a-8232-e431b1c69d8d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@nickpeihl nickpeihl changed the title [Dashboards as Code] Dashboard Delete endpoint should return 204 [Dashboards as Code] Unify Dashboard endpoint status codes with other As Code APIs Mar 18, 2026
ThomThomson
ThomThomson approved these changes Mar 18, 2026
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work making this more RESTful. LGTM!

@nickpeihl nickpeihl requested review from a team as code owners March 18, 2026 21:04
jasonrhodes
jasonrhodes approved these changes Mar 18, 2026
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM, glad to see us make these changes to our APIs.

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 18, 2026

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Project:Dashboards API release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickpeihl @elasticmachine @jasonrhodes @ThomThomson