Set 45m timeout to exhaustive pipeline jobs. #18362
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
|
mashhurs
force-pushed
the
set-timeout-to-exhaustive-pipeline
branch
from
5b0748f to
f5f6995
Compare
catalog-info.yaml
Outdated
| spec: | ||
| repository: elastic/logstash | ||
| pipeline_file: ".buildkite/exhaustive_tests_pipeline.yml" | ||
| maximum_timeout_in_minutes: 90 |
There was a problem hiding this comment.
| maximum_timeout_in_minutes: 90 | |
| maximum_timeout_in_minutes: 120 |
Commit message and PR title say 120. I think that is a safer default (if there are multiple retries, we can push up on 90)
There was a problem hiding this comment.
Initially I thought we set timeout to entire pipeline (since the definition in catalog-info) run but figured out it is for per job. Is there possibility each job can run more than 90 min?
(I have updated the PR title and desc)
There was a problem hiding this comment.
Oh, in that case it should actually be much lower. IF a cell is running longer than 45 mins something is terribly wrong. (in most cases it should be under 30)
There was a problem hiding this comment.
Nice, that sounds good for me now. I will update it to 45.
There was a problem hiding this comment.
FYI: CI will be updated due to catalog-info change so no need to run CIs on PR. That's why merged.
mashhurs
changed the title
mashhurs
changed the title
Update timeout to 45m
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @mashhurs |
3 participants
Release notes
[rn:skip]
What does this PR do?
Sets 45 min timeout to exhaustive pipeline CI jobs.
Why is it important/What is the impact to the user?
No user impact
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature works