Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-model.asciidoc #4233

Closed
wants to merge 1 commit into from
Closed

Update data-model.asciidoc #4233

wants to merge 1 commit into from

Conversation

stevejsyu
Copy link

Per the PR and changelogs, the error.custom and transaction.custom fields were changed to the flattened type since 8.12.0, but it does not reflect the change in this document.

In addition, the documentation describes these fields as "non-indexed." In SF case 01746372, the customer reported that these fields are searchable in Discover within Kibana, indicating they may actually be indexed.

Per the PR and changelogs, the `error.custom` and `transaction.custom` fields were changed to the `flattened` type, but it does not reflect the change in this document.

- PR: [#12102](elastic/apm-server#12102)
- Changelogs: [APM Release Notes 8.12](https://www.elastic.co/guide/en/observability/current/apm-release-notes-8.12.html#_added_7)

In addion, the documentation describes these fields as "non-indexed." In SF case 01746372, the customer reported that these fields are searchable in Discover within Kibana, indicating they may actually be indexed.
@stevejsyu stevejsyu requested a review from a team as a code owner September 10, 2024 08:06
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis added the backport-main Automated backport with mergify label Sep 10, 2024
@colleenmcginnis
Copy link
Contributor

In addition, the documentation describes these fields as "non-indexed." In SF case 01746372, the customer reported that these fields are searchable in Discover within Kibana, indicating they may actually be indexed.

Maybe @axw can confirm that the field is not indexed. 👋

@axw
Copy link
Member

axw commented Sep 11, 2024

The use of flattened in .custom fields was reverted in elastic/elasticsearch#108227. So there was a period of time where they were indexed, but not now.

@bmorelli25 bmorelli25 added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@bmorelli25 bmorelli25 closed this Sep 16, 2024
@bmorelli25 bmorelli25 deleted the stevejsyu-patch-1 branch September 16, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-main Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants