forked from open-telemetry/opentelemetry-demo
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s example #11
Merged
Merged
Add k8s example #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
ChrsMark
force-pushed
the
add_k8s_example
branch
2 times, most recently
from
November 23, 2023 08:11
dd9131c
to
ddb7e3a
Compare
github-actions
bot
force-pushed
the
main
branch
3 times, most recently
from
November 28, 2023 03:26
fcb2211
to
2976dd4
Compare
ChrsMark
force-pushed
the
add_k8s_example
branch
from
November 28, 2023 12:07
cd47e54
to
8ee60c6
Compare
github-actions
bot
force-pushed
the
main
branch
from
November 28, 2023 12:11
aed7d96
to
53acb31
Compare
ChrsMark
force-pushed
the
add_k8s_example
branch
from
November 28, 2023 12:21
8ee60c6
to
8e33b54
Compare
ChrsMark
force-pushed
the
add_k8s_example
branch
from
November 29, 2023 10:30
8e33b54
to
1f387ce
Compare
@AlexanderWert this is ready for a review now. |
elastic-apm-tech
force-pushed
the
main
branch
from
November 29, 2023 18:28
63fb097
to
1af60be
Compare
ChrsMark
force-pushed
the
add_k8s_example
branch
from
November 30, 2023 11:05
c6a0c17
to
94b22cb
Compare
elastic-apm-tech
force-pushed
the
main
branch
2 times, most recently
from
December 4, 2023 09:26
757ce6f
to
7d1e834
Compare
ChrsMark
force-pushed
the
add_k8s_example
branch
from
December 4, 2023 09:30
94b22cb
to
8cf14cb
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
AlexanderWert
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a section in the
values.yaml
in order to provide an example on how to enable Kubernetes cluster monitoring.This PR also adds a
daemonset.yaml
file which can be used in order to deploy an additional Otel collector for Node level metrics collection and Autodiscovery.Note that for now node level metrics+logs collection cannot be enabled at the same time (same helm chart) with cluster level metrics collection because those 2 require different deployment modes (daemonset VS deployment).
That's why we introduce an additional Daemonset for the Node level metrics collection.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsSample custom dashboards