Finalizes post-setup script and updates docs #110
Merged
+122
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrhodes
force-pushed
the
post-setup-docs
branch
from
fed6270
to
1ce4caf
Compare
jasonrhodes
force-pushed
the
post-setup-docs
branch
from
1ce4caf
to
ea29186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
post-setupshould now work properly, but you will need to pay attention to the env vars that are required in .env.exampleI've removed KIBANA_API_KEY and replaced it with KIBANA_USER and KIBANA_PASSWORD because I think they will be more reliable and easier to reason about (the EEM enablement PUT request fails with the API key but works with the user/pass).
I've also removed the synthetics setup stuff from the main setup script, as @andrewvc has gotten synthetics up and running using a different path. We can revisit that later.