[DEVOPS-3113] Add ability to version static assets #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icVersion to improve clarity. Add static folder path in siteUtils.
…atible. Add helper function get versions json size.
…ion name as asset files are being versioned rather than just simply being moved elsewhere.
…ionalities of Node JS 14
…. Change to relative paths in versioning assets.
…logic to check if docs is versioned for the first time to make the proper path updates. Accept sitepaths from versioning function.
…sion function. Add an if logic to check if static asset versioning needs to be done. Add better descriptions for the CLI options
pa-eps
suggested changes
Nov 22, 2021
…o check whether the next path exists by checking if there is access to it. Add comments accordingly .
…encies because it is needed to test non-exported functions.
…the comment in the createVersion file.
…variable name to directory from folder to be consistent with naming.
pa-eps
suggested changes
Nov 25, 2021
…ts. Pass in next directly instead of setting it to a variable because it won't be used elsewhere and change logic in theremove function accordingly. Change variable name from assets to docs assets for clarity.
pa-eps
suggested changes
Nov 25, 2021
…et type is being versioned for the first time.
…. Remove console.log in staticVersioner and add static type variable to console.info to provide better information. Add package.json file.
…rsion. Add yarn.lock file.
…reateVersion includes new logic for versioning static assets and error-handling.
pa-eps
suggested changes
Nov 29, 2021
…ync. Remove sinon-chai and upgrade commander version to latest. Since commander version is upgraded, remove storeOptionsAsProperties option. Add comments in staticVersioner.js to improve clarity and move the copyDirectory function in to the then and catch blocks. Include yarn.lock file.
…ningTest.js file. Capitalize the beginning of comments for consistency.
…exclusions. Reorganize test, add describes, and change the descriptions to improve clarity.
…e has been versioned already so the right regex can be searched and replaced.
pa-eps
suggested changes
Dec 1, 2021
…e variables are not being used again. Change staticDir description.
…mprove clarity. Fix the comment for the versionStaticAssets function to improve clarity. Rename relativeLinkPattern to searchPattern to improve clarity.
…and add negative tests for the private functions.
… it provided no additional check.
…s core functionalities.
…better clarity. Add .idea to .gitignore.
pa-eps
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature to version one or more static assets under
website/static/directory of Docusaurus V1 site structure.This PR closes issue #3