Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix #9

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Improve and fix #9

wants to merge 19 commits into from

Conversation

bueltge
Copy link

@bueltge bueltge commented Mar 25, 2020

Thanks a lot of the Dropin, fine solution.
I fix two topics inside the code to get more solid usage and add more solid source code to maintain easier. I enhance also the composer.json to use them via composer workflow and add the necessary dependencies.

Small hint in content of method incr(). I mean you should return only one type of return type, in your case Integer. Maybe you should remove the false and use 0 as value for failures.
Best regards

@elcobvg
Copy link
Owner

elcobvg commented Jun 24, 2020

Thanks for your contributions, @bueltge! Unfortunately, I have very little time at the moment. I'm not familiar with Palm, what is it supposed to do?

@bueltge
Copy link
Author

bueltge commented Jun 24, 2020

Hey @elcobvg
Thanks for your feedback. I would improve the class and Psalm help me a lot on this. Psalm is a static analysis tool for PHP that helps you identify both obvious and hard-to-spot bugs in your code. The checks and notes are really helpful.

example
via ./vendor/bin/psalm --show-info=true inside the terminal

result
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants