Skip to content

Add path filtering to TS workflows to skip them for Elixir-only changes #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alco wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add path filtering to TS workflows to skip them for Elixir-only changes #4069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6177342
Add agent task files for ts-workflow-path-filtering
erik-the-implementer Mar 27, 2026
1f081c4
Replace custom gate job with native GitHub paths filtering for TS wor…
erik-the-implementer Mar 27, 2026
2f67984
Update progress log
erik-the-implementer Mar 27, 2026
132ea3d
Add patches/** to TS workflow trigger paths
erik-the-implementer Mar 27, 2026
cba38b4
Add .agent-tasks to .prettierignore
erik-the-implementer Mar 27, 2026
4ea2695
Remove agent task files
erik-the-implementer Mar 27, 2026
43b165e
Simplify TS workflow path filtering: use paths-ignore instead of allo…
erik-the-implementer Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ts_check_formatting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
name: TS formatting

on:
push:
branches: ['main', 'changeset-release/main']
pull_request:
paths-ignore:
- '**/README.md'
- 'integration-tests/**'
- 'packages/sync-service/**'
- 'packages/electric-telemetry/**'
- 'packages/elixir-client/**'
- 'packages/sync-service/**'

permissions:
contents: read
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/ts_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@ name: TS tests

on:
push:
branches: ['main']
paths-ignore:
- 'website/**'
- '**/README.md'
- 'integration-tests/**'
branches: ['main', 'changeset-release/main']
pull_request:
paths-ignore:
- 'website/**'
- '**/README.md'
- 'integration-tests/**'
- 'packages/sync-service/**'
- 'packages/electric-telemetry/**'
- 'packages/elixir-client/**'
Comment on lines +11 to +13
Copy link
Copy Markdown
Contributor

@msfstef msfstef Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS tests include integration tests with the sync service, so I don't think it's a bad idea to be running them with sync service changes

Copy link
Copy Markdown
Member Author

@alco alco Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a contentious point. In principle, we could run all tests on every changes, but it gets impractical due to the minute-long runtimes. Once a PR is opened and it then evolves via small changes, some cosmetic, some logical, having to wait for the whole CI to finish running on every push is detrimental to productivity.

I think it's a matter of discipline: if we can as a team get into the habit of shipping narrow-focused changes fast and have integration tests run at a slower cadence (cron job, release PR, pushed to main only, etc.) we can increase our velocity while keeping quality regressions in check.

Copy link
Copy Markdown
Contributor

@msfstef msfstef Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that all TS tests run right now, but having the TS client alone run with sync service changes is neither slow (they run in parallel) nor too much

happy to skip them but I'd be worried about client-server incompatibilities sneaking in - although they'd still show up on main anyway as you said so perhaps not. that much of an issue


permissions:
contents: read
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ packages/sync-service
_build
deps
integration-tests

# Ignore agent task files
.agent-tasks
Loading