Skip to content

chore(sync-service): instrument snapshot query timing#4110

Open
KyleAMathews wants to merge 1 commit intomainfrom
codex/snapshot-query-instrumentation
Open

chore(sync-service): instrument snapshot query timing#4110
KyleAMathews wants to merge 1 commit intomainfrom
codex/snapshot-query-instrumentation

Conversation

@KyleAMathews
Copy link
Copy Markdown
Contributor

Summary

  • add a top-level snapshot query span around SnapshotQuery.execute_for_shape/4
  • record checkout wait, setup, query, and total durations for snapshot-backed requests
  • emit a telemetry event tagged with query_reason so subset, move-in, and initial snapshot paths can be separated in analysis

Verification

  • mix compile in packages/sync-service
  • mix test test/electric/shape_cache_test.exs in packages/sync-service (real-db cases fail here because local Postgres on localhost:54321 is unavailable in this environment)

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit cdea4ee
🔍 Latest deploy log https://app.netlify.com/projects/electric-next/deploys/69d81a90d0d81d000896b98a
😎 Deploy Preview https://deploy-preview-4110--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.67%. Comparing base (c740930) to head (cdea4ee).
⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4110   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          25       25           
  Lines        2438     2438           
  Branches      615      611    -4     
=======================================
  Hits         2162     2162           
  Misses        274      274           
  Partials        2        2           
Flag Coverage Δ
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/start 82.83% <ø> (ø)
packages/typescript-client 93.81% <ø> (ø)
packages/y-electric 56.05% <ø> (ø)
typescript 88.67% <ø> (ø)
unit-tests 88.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant