feat: add variadic function support to eval#4114
Open
icehaunter wants to merge 3 commits intomainfrom
Open
Conversation
Teach the eval stack to define, resolve, parse, and execute variadic postgres-style functions. This adds VARIADIC support to defpostgres definitions, expands variadic overloads during function lookup, and preserves the existing packed variadic AST/runtime calling convention. It also lowers PostgreSQL special-form AST nodes for coalesce, greatest, and least through the shared function path, and exposes those three functions in the known function registry. Tests were added first in parser and runner coverage for overload resolution, packed variadic AST shape, and nil-handling semantics.
Clarify the Func field comments, reject explicit VARIADIC calls until they are fully supported, and harden variadic argument packing. This also adds parser coverage for explicit VARIADIC rejection and for preferring exact non-variadic overloads over variadic expansions.
Evaluate coalesce arguments lazily in both parser reduction and runtime execution so unreachable branches are not forced eagerly. This preserves constant-folding for leading NULL branches, avoids reducing later dead branches once coalesce has a decisive argument, and adds regression tests for parser and runner short-circuit behavior.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defpostgresdefinitions and overload lookup supportcoalesce,greatest, andleastthrough the shared function parsing and execution pathVARIADICcalls and precedence between exact and variadic overloadscoalesceshort-circuiting in parser reduction and runtime executionTesting