ci: use x86_64 Node.js for some macOS jobs #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
ci-x64-macos
branch
from
6a73086 to
de240cf
Compare
dsanders11
force-pushed
the
ci-x64-macos
branch
from
de240cf to
4c654ff
Compare
erikian
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1435 pointed out that
mac-test-x64is running on Apple Silicon now, so use Rosetta to run the tests under an x86_64 Node.js. In the case of that PR it would have made more clear that the tests were only failing on Apple Silicon, not Intel macOS, and been quicker to debug.