Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a vendor directory option to use a custom vendor #526

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

beyondkmp
Copy link
Contributor

Doing this has two benefits:

  1. Users can use their own compiled and modified version of Squirrel Windows.
  2. Users can perform their own checks during the download to ensure the executables in the vendor directory have not been tampered with.

@beyondkmp beyondkmp requested a review from a team as a code owner July 21, 2024 05:55
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beyondkmp This is looking pretty good - and something that scares us maintainers a lot less than upgrading NuGet or 7-zip directly because letting people customize their vendors comes without any backwarts compat issues. We don't have any specific reason to suspect that either the 7Zip or NuGet upgrade would break anything, but then again, we haven't tested it either - and if they do break things, we'd rather not be on the hook for fixing it 😉 Your change here seems like a great solution!

Thank you!

(Note for others: Check out the changes without whitespace changes)

@felixrieseberg felixrieseberg merged commit a18e3c6 into electron:main Jul 23, 2024
3 checks passed
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants