Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3967: Do not require UIA when first uploading cross signing keys #3471

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Dec 21, 2024

Playing around with Copilot, tests are generated.

Requires matrix-org/gomatrixserverlib#444

@S7evinK S7evinK requested a review from a team as a code owner December 21, 2024 20:13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are separated for readability, as I think table tests would make them harder to read.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.31034% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.38%. Comparing base (add73ec) to head (e05504c).

Files with missing lines Patch % Lines
clientapi/routing/key_crosssigning.go 78.94% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3471      +/-   ##
==========================================
- Coverage   49.39%   49.38%   -0.01%     
==========================================
  Files         524      524              
  Lines       59737    59771      +34     
==========================================
+ Hits        29507    29520      +13     
- Misses      26748    26766      +18     
- Partials     3482     3485       +3     
Flag Coverage Δ
unittests 49.38% <79.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants