Rotate firebase token in case of error

[bmarty]

Content

Add a quick fix for the troubleshoot notification test in case of PusherRejected error, which means that the token is unknown.

In this case, the quick fix will rotate the Firebase token.

Note: maybe later we will see if we can do the same thing for UnifiedPush provider.

Motivation and context

Closes #3752

Screenshots / GIFs

You can see in the video below that when clicking on QuickFix, the token is rotated.

FirebaseTokenRotation.mp4

Tests

• @wrenix can you check if this is fixing your issue please?

Internally, this can be tested by patching the code and let DefaultPushService.testPush() throw a PushGatewayFailure.PusherRejected() (this is what I have done for the video above).

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oHbM5B

[jmartinesp]

I haven't tried it yet, but the code LGTM, just a couple of suggestions.

[jmartinesp]

Not a needed change, but an early return here with !isPlayServiceAvailable.isAvailable() might be more readable. Also, for the exception, maybe a throw Exception(...).also(Timber::e) might work?

[bmarty]

I will change. I am also wondering why we throw the exception here and we do not invoke continuation.resumeWithException(e) 🤔

[bmarty]

12f5839

[jmartinesp]

I think the comment should be in the interface instead?

[bmarty]

Yes, thanks! 12f5839

[codecov]

Codecov Report

Attention: Patch coverage is 30.55556% with 50 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (4a24668) to head (12f5839).
Report is 10 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ies/pushproviders/firebase/FirebaseTokenDeleter.kt	0.00%	13 Missing ⚠️
...ries/pushproviders/firebase/FirebaseTokenGetter.kt	0.00%	13 Missing ⚠️
.../libraries/pushproviders/firebase/FirebaseStore.kt	0.00%	8 Missing ⚠️
...ies/pushproviders/firebase/FirebaseTokenRotator.kt	0.00%	7 Missing ⚠️
...braries/push/impl/troubleshoot/PushLoopbackTest.kt	60.00%	0 Missing and 2 partials ⚠️
...s/pushproviders/firebase/FirebaseTroubleshooter.kt	0.00%	2 Missing ⚠️
...s/pushproviders/firebase/IsPlayServiceAvailable.kt	0.00%	2 Missing ⚠️
...ndroid/libraries/pushproviders/api/PushProvider.kt	0.00%	1 Missing ⚠️
...ies/pushproviders/firebase/FirebasePushProvider.kt	66.66%	1 Missing ⚠️
...s/pushproviders/unifiedpush/UnifiedPushProvider.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3755      +/-   ##
===========================================
- Coverage    83.10%   83.03%   -0.07%     
===========================================
  Files         1771     1775       +4     
  Lines        44415    44461      +46     
  Branches      5207     5212       +5     
===========================================
+ Hits         36909    36920      +11     
- Misses        5674     5707      +33     
- Partials      1832     1834       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud