Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add store cache for account management URLs. #4109

Closed
wants to merge 1 commit into from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 3, 2025

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Jan 3, 2025
Copy link

sonarqubecloud bot commented Jan 3, 2025

Copy link
Contributor

github-actions bot commented Jan 3, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HmX42n

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (5880bbb) to head (e82855f).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ences/impl/store/DefaultSessionPreferencesStore.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4109   +/-   ##
========================================
  Coverage    83.27%   83.28%           
========================================
  Files         1884     1885    +1     
  Lines        49068    49099   +31     
  Branches      5760     5766    +6     
========================================
+ Hits         40862    40892   +30     
- Misses        6139     6142    +3     
+ Partials      2067     2065    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant