Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sticker mimetype fallback to image #4111

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

surakin
Copy link
Contributor

@surakin surakin commented Jan 4, 2025

Fixes #4110

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

…s an image anyway.

Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.26%. Comparing base (5880bbb) to head (647dcc7).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ctories/event/TimelineItemContentStickerFactory.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4111      +/-   ##
===========================================
- Coverage    83.27%   83.26%   -0.01%     
===========================================
  Files         1884     1884              
  Lines        49068    49068              
  Branches      5760     5760              
===========================================
- Hits         40862    40858       -4     
- Misses        6139     6140       +1     
- Partials      2067     2070       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@surakin surakin marked this pull request as ready for review January 4, 2025 19:30
@surakin surakin requested a review from a team as a code owner January 4, 2025 19:30
@surakin surakin requested review from ganfra and removed request for a team January 4, 2025 19:30
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Jan 6, 2025
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, make sense. Can you sign the CLA please?

@surakin
Copy link
Contributor Author

surakin commented Jan 6, 2025

There you go

@bmarty bmarty merged commit a33266c into element-hq:develop Jan 6, 2025
22 of 24 checks passed
@surakin surakin deleted the sticker-mimetype-fallback branch January 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open sticker media if the mimetype is missing
3 participants