Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync times have regressed significantly since Ignition launch #2062

Open
ara4n opened this issue Nov 10, 2023 · 7 comments
Open

Sync times have regressed significantly since Ignition launch #2062

ara4n opened this issue Nov 10, 2023 · 7 comments
Labels
A-Performance A-Sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Nov 10, 2023

Steps to reproduce

  1. Foreground the app in a big account
  2. Stare at the sync spinner for 4+ seconds
  3. Feel very sad that previously it was syncing in ~1s.

Kegan has dug into a rageshake, and is seeing an inexplicable 3s gap in clientside logs (see rageshake for details). This behaviour started at some point in the last month or so - perhaps when backup got added?

The regression hasn't been picked up by the perftest jig.

Outcome

What did you expect?

Instant sync

What happened instead?

Sync regressing.

Your phone model

No response

Operating system version

No response

Application version

433

Homeserver

No response

Will you send logs?

Yes

@ara4n
Copy link
Member Author

ara4n commented Nov 11, 2023

image

@stefanceriu
Copy link
Member

I followed this up on the rageshake and I inspected startup network traffic but there's nothing that points at anything having slowed down client/sdk side. There was a problem in a previous key backup implementation re startup request that but that has since been fixed.
I will close this until we get more data to work with.

@kittykat kittykat added A-Sync S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Performance labels Nov 20, 2023
@ara4n
Copy link
Member Author

ara4n commented Nov 22, 2023

so where is the slowdown coming from in the rageshake? i'm seeing it reliably on every launch.

@ara4n ara4n reopened this Nov 22, 2023
@stefanceriu
Copy link
Member

so where is the slowdown coming from in the rageshake

There were 2 similar rageshakes, I commented on the other one here https://github.com/vector-im/element-x-ios-rageshakes/issues/1074#issuecomment-1810069242

tl;dr; app starts sync -> 2 seconds later sync comes back with 594kiB(!) of data -> takes 1 second to process rust side, app finally gets it

@ara4n
Copy link
Member Author

ara4n commented Jan 30, 2024

this is still markedly slower than in sept

@Avi0n
Copy link

Avi0n commented Jan 31, 2024

Seeing ~4 sec here as well. Seems to happen to me when the app has been in the background for a while. Submitted logs referencing this issue.

edit: Today I had a sync that took almost 10 seconds! Submitted another set of logs.

@ara4n
Copy link
Member Author

ara4n commented Oct 13, 2024

this has totally changed with the move to SSS. it’s still not as fast as it could be, but it’s faster than it was. element-hq/synapse#17722 might also contribute to perf problems.

keeping this open as it’s still way slower than the original launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Performance A-Sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants