Merged
Conversation
ac1cbaf to
db0f521
Compare
Generated by 🚫 Danger Swift against fd9abe6 |
❌ 3 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
f53a00a to
eded98e
Compare
2bfd64e to
ba3a0f2
Compare
stefanceriu
reviewed
Dec 5, 2024
Member
stefanceriu
left a comment
There was a problem hiding this comment.
Very nice! Left some minor comments but otherwise looks good to me!
ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestCell.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenModels.swift
Show resolved
Hide resolved
58000f3 to
30d3c34
Compare
of the banner
improved code and the tests
and improved the knock requests tests for the room screen
so I renamed it also on the app side
30d3c34 to
fd9abe6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Ready for review, but before merging it we need the following PR to be merged in main, on the SDK:
matrix-org/matrix-rust-sdk#4338
fixes #3422
Simulator.Screen.Recording.-.iPhone.16.-.2024-12-05.at.12.28.58.mp4