Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically retry decryptions in the active room when the app becomes active again just in case the NSE received keys we're not aware of #3628

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

stefanceriu
Copy link
Member

What it says on the tin.

…es active again just in case the NSE received keys we're not aware of.
@stefanceriu stefanceriu added the pr-misc for other changes label Dec 17, 2024
@stefanceriu stefanceriu marked this pull request as ready for review December 17, 2024 09:43
@stefanceriu stefanceriu requested a review from a team as a code owner December 17, 2024 09:43
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team December 17, 2024 09:43
Copy link

codecov bot commented Dec 17, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
906 1 905 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 25.66% (Passed 84 times, Failed 29 times)

Stack Traces | 4.71s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9968624 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu changed the title Automatically retry decryptions in the active room when the app becom…es active again just in case the NSE received keys we're not aware of Automatically retry decryptions in the active room when the app becomes active again just in case the NSE received keys we're not aware of Dec 17, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7f3cdd8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants