Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the interactive dismiss gesture of media previews on iOS 18.2 #3636

Closed
wants to merge 1 commit into from

Conversation

pixlwave
Copy link
Member

The root view was being ignored (well for gestures anyway) as it was clear.

The root view was being ignored as it was clear.
@pixlwave pixlwave requested a review from a team as a code owner December 18, 2024 09:52
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 18, 2024 09:52
Copy link
Member Author

@pixlwave pixlwave Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timing of this being called changed from after the animation had completed (which presumably was to do with the preview controller as it doesn't make sense looking at the navigation stack code), to as soon as you lift your finger on the drag (which is too early to undo the flip).

Copy link

github-actions bot commented Dec 18, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b0e1602

Copy link

codecov bot commented Dec 18, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
906 1 905 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 23.68% (Passed 58 times, Failed 18 times)

Stack Traces | 4.63s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.959198 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 18, 2024
@pixlwave
Copy link
Member Author

Closing this for now, it breaks interaction with the QL controller 🤦‍♂️

@pixlwave pixlwave closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant