Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security and privacy part 2 #3637

Merged
merged 18 commits into from
Jan 15, 2025
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 18, 2024

WIP, requires some SDK API that are still in review

What is left to do:

  • - Handle the save actions in both the edit address screen and the security and privacy screen
  • - This may require some pairing with the SDK team, to understand what is the correct to call these APIs based on the codependent states of the view
  • - There might be some redesigns incoming regarding the room address part to handle admins from different HSs
  • - Unit tests

@Velin92 Velin92 requested a review from a team as a code owner December 18, 2024 10:31
@Velin92 Velin92 requested review from stefanceriu and removed request for a team December 18, 2024 10:31
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 18, 2024
@Velin92 Velin92 marked this pull request as draft December 18, 2024 10:31
Copy link

github-actions bot commented Dec 18, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e12a325

Copy link

codecov bot commented Dec 18, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 14.67% (Passed 128 times, Failed 22 times)

Stack Traces | 1.29s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.91485596 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's see how this evolves rules wise

@stefanceriu stefanceriu force-pushed the mauroromito/sec_and_private_part_2 branch from ba28461 to d802711 Compare January 10, 2025 17:18
@stefanceriu stefanceriu marked this pull request as ready for review January 15, 2025 09:49
@stefanceriu
Copy link
Member

Will merge this now to avoid conflicts with other incoming SDK updates and will follow it up with logic changes + unit tests

@stefanceriu stefanceriu merged commit e3ad925 into develop Jan 15, 2025
7 checks passed
@stefanceriu stefanceriu deleted the mauroromito/sec_and_private_part_2 branch January 15, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants