-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security and privacy part 2 #3637
Conversation
Generated by 🚫 Danger Swift against e12a325 |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's see how this evolves rules wise
ElementX/Sources/Screens/SecurityAndPrivacyScreen/View/SecurityAndPrivacyScreen.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/SecurityAndPrivacyScreen/SecurityAndPrivacyScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EditRoomAddressScreen/EditRoomAddressScreenViewModel.swift
Show resolved
Hide resolved
visibility state
added also the preview tests
and improved handling of the access -> vsibility reaction. Also added a simple error handling for the public directory toggle
but is missing its full implementation
when editing the address
ba28461
to
d802711
Compare
Quality Gate passedIssues Measures |
Will merge this now to avoid conflicts with other incoming SDK updates and will follow it up with logic changes + unit tests |
WIP, requires some SDK API that are still in review
What is left to do: