Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the RustSDK to version 24.12.20 #3647

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bump the RustSDK to version 24.12.20 #3647

merged 1 commit into from
Dec 20, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner December 20, 2024 13:51
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team December 20, 2024 13:51
@stefanceriu stefanceriu added the pr-misc for other changes label Dec 20, 2024
pixlwave
pixlwave approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like reviews like this

@github-actions GitHub Actions
Copy link

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against 73334da

@stefanceriu
Copy link
Member Author

I like reviews like this

Yeah, why can't they all be like that!? :))

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefanceriu
Copy link
Member Author

⚠️ Please provide a description for this PR.

image

Hywan
Hywan approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review was rather complex. Please consider splitting your patches in smaller commits next time.

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the top 1 failed tests by shortest run time 
MediaUploadPreviewScreenViewModelTests testVideoUploadWithoutCaption()
Stack Traces | 11.8s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Other/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu merged commit 9a00b98 into develop Dec 20, 2024
10 checks passed
@stefanceriu stefanceriu deleted the stefan/sdkBump branch December 20, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Hywan Hywan Hywan approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @Hywan @pixlwave