Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Compound and RTE from license acknowledgements. #3661

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 6, 2025

These all come from element-hq so aren't third-party licenses to us.

These all come from element-hq so aren't third-party licenses to us.
@pixlwave pixlwave added the pr-misc for other changes label Jan 6, 2025
@pixlwave pixlwave requested a review from a team as a code owner January 6, 2025 11:13
@pixlwave pixlwave requested review from Velin92 and manuroe and removed request for a team January 6, 2025 11:13
Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @pixlwave. It was actually easy to do as you said 👍 .

Copy link

codecov bot commented Jan 6, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
909 2 907 0
View the top 1 failed tests by shortest run time
PreviewTests test_joinRoomScreen()
Stack Traces | 2.02s run time
failed - Snapshot "Invite" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Invite.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Invite.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.96554565 is less than required 1.0
The lowest perceptual color precision 0.18624997 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 10.94% (Passed 114 times, Failed 14 times)

Stack Traces | 1.35s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.92681885 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@pixlwave
Copy link
Member Author

pixlwave commented Jan 6, 2025

It was actually easy to do as you said 👍 .

All part of the magic of open source tools ✨

@pixlwave pixlwave merged commit 307a593 into develop Jan 6, 2025
15 checks passed
@pixlwave pixlwave deleted the doug/ignore-internal-acknowledgements branch January 6, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants