Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify how to we handle background task expirations. #3670

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

@stefanceriu stefanceriu requested a review from a team as a code owner January 10, 2025 11:22
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team January 10, 2025 11:22
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤞

@stefanceriu stefanceriu added the pr-misc for other changes label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 13.48% (Passed 122 times, Failed 19 times)

Stack Traces | 1.44s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.92681885 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu merged commit 2671d90 into develop Jan 10, 2025
10 checks passed
@stefanceriu stefanceriu deleted the stefan/backgroundTaskCrash branch January 10, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants