Refactor the JoinRoom screen to take advantage of newer APIs and support more joinRule/membership combinations (i.e. invite required, restricted, banned) #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort more joinRule/membership combinations (i.e. invite required, restricted, banned) - expose the full RoomPreview and RoomMembershipDetails through their own proxies - implement standard mocks for all the different combinations - converge on a single room info provider - rebuild all the previews
Generated by 🚫 Danger Swift against 231adbe |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3685 +/- ##
===========================================
+ Coverage 78.50% 78.62% +0.11%
===========================================
Files 792 792
Lines 67338 67897 +559
===========================================
+ Hits 52864 53381 +517
- Misses 14474 14516 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Jan 20, 2025
ElementX/Sources/Screens/JoinRoomScreen/JoinRoomScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/JoinRoomScreen/JoinRoomScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/JoinRoomScreen/View/JoinRoomScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/JoinRoomScreen/View/JoinRoomScreen.swift
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
Jan 20, 2025
stefanceriu
force-pushed
the
stefan/betterRoomPreviews
branch
from
f95dbd7 to
5aac543
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3677, fixes #3678