Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to filter by state event type on admin room state endpoint #18035

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Add the ability to filter by state event type on admin room state endpoint #18035

merged 6 commits into from
Jan 8, 2025

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Dec 16, 2024

Adds a query param type to /_synapse/admin/v1/rooms/{room_id}/state that filters the state event query by state event type.

@H-Shay H-Shay requested a review from a team as a code owner December 16, 2024 21:48
@github-actions github-actions bot deployed to PR Documentation Preview December 16, 2024 21:50 Active
@github-actions github-actions bot deployed to PR Documentation Preview December 16, 2024 21:51 Active
anoadragon453
anoadragon453 requested changes Dec 23, 2024
View reviewed changes
synapse/rest/admin/rooms.py Outdated Show resolved Hide resolved
docs/admin_api/rooms.md Outdated Show resolved Hide resolved
changelog.d/18035.feature Outdated Show resolved Hide resolved
tests/rest/admin/test_room.py Show resolved Hide resolved
tests/rest/admin/test_room.py Outdated Show resolved Hide resolved
@github-actions github-actions bot deployed to PR Documentation Preview January 2, 2025 21:13 Active
@H-Shay H-Shay requested a review from anoadragon453 January 3, 2025 00:10
anoadragon453
anoadragon453 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tests/rest/admin/test_room.py Outdated Show resolved Hide resolved
@github-actions github-actions bot deployed to PR Documentation Preview January 3, 2025 15:05 Active
@H-Shay H-Shay force-pushed the shay/admin_filter_state branch from 25c0726 to 46d5240 Compare January 3, 2025 18:03
@github-actions github-actions bot deployed to PR Documentation Preview January 3, 2025 18:04 Active
anoadragon453
anoadragon453 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks!

changelog.d/18035.feature Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 merged commit e34fd12 into element-hq:develop Jan 8, 2025
20 checks passed
@github-actions github-actions bot deployed to PR Documentation Preview January 8, 2025 15:38 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H-Shay @anoadragon453