Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to verify remote user messages can be redacted via admin api redaction endpoint if requester is admin in room #18043

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Add a test to verify remote user messages can be redacted via admin api redaction endpoint if requester is admin in room #18043

merged 3 commits into from
Jan 3, 2025

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Dec 20, 2024 •
edited by anoadragon453
Loading

A test for #18029.

@H-Shay H-Shay requested a review from a team as a code owner December 20, 2024 20:52
@H-Shay H-Shay marked this pull request as draft December 20, 2024 20:53
@H-Shay H-Shay changed the title Add a test to verify remote user messages can be redacted via admin api redaction enpoint if requester is admin in room Add a test to verify remote user messages can be redacted via admin api redaction endpoint if requester is admin in room Dec 20, 2024
@H-Shay H-Shay mentioned this pull request Dec 20, 2024
Merged
3 tasks
anoadragon453
anoadragon453 requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests, otherwise LGTM. Thanks for taking the initiative and writing this up proactively!

changelog.d/18043.bugfix Outdated Show resolved Hide resolved
tests/rest/admin/test_user.py Outdated Show resolved Hide resolved
tests/rest/admin/test_user.py Outdated Show resolved Hide resolved
@H-Shay H-Shay marked this pull request as ready for review January 2, 2025 18:48
@H-Shay H-Shay requested a review from anoadragon453 January 2, 2025 19:10
anoadragon453
anoadragon453 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for being proactive and taking this on!

@anoadragon453 anoadragon453 merged commit b526767 into element-hq:develop Jan 3, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H-Shay @anoadragon453