element-hq · c-cal · Jan 20, 2025 · Jan 20, 2025 · Jan 21, 2025 · Jan 23, 2025
@@ -0,0 +1,3 @@
+Fixed a bug that disturbed room creation when a check_event_allowed callback was registered by a module and power_level Notifications mapping exists.
+
+Contributed by @c-cal
diff --git a/synapse/push/bulk_push_rule_evaluator.py b/synapse/push/bulk_push_rule_evaluator.py
@@ -59,6 +59,7 @@
 from synapse.util import unwrapFirstError
 from synapse.util.async_helpers import gather_results
 from synapse.util.caches import register_cache
+from synapse.util.frozenutils import unfreeze
 from synapse.util.metrics import measure_func
 from synapse.visibility import filter_event_for_clients_with_state
 
@@ -412,7 +413,7 @@ async def _action_for_event_by_user(
         # Note that this is done automatically for the sender's power level by
         # _get_power_levels_and_sender_level in its call to get_user_power_level
         # (even for room V10.)
-        notification_levels = power_levels.get("notifications", {})
+        notification_levels = unfreeze(power_levels.get("notifications", {}))
 # Ensure that the event is frozen, to make sure that the module is not tempted 
 # to try to modify it. Any attempt to modify it at this point will invalidate 
 # the hashes and signatures. 
 event.freeze() 
 for callback in self._check_event_allowed_callbacks: 
     try: 
         res, replacement_data = await delay_cancellation( 
             callback(event, state_events) 
         ) 
     except CancelledError: 
         raise 
     except SynapseError as e: 
         # FIXME: Being able to throw SynapseErrors is relied upon by 
         # some modules. PR https://github.com/matrix-org/synapse/pull/10386 
         # accidentally broke this ability. 
         # That said, we aren't keen on exposing this implementation detail 
         # to modules and we should one day have a proper way to do what 
         # is wanted. 
         # This module callback needs a rework so that hacks such as 
         # this one are not necessary. 
         raise e 
     except Exception: 
         raise ModuleFailedException( 
             "Failed to run `check_event_allowed` module API callback" 
         ) 
 # Ensure that the event is frozen, to make sure that the module is not tempted 
 # to try to modify it. Any attempt to modify it at this point will invalidate 
 # the hashes and signatures. 
 event.freeze() 
  
 for callback in self._check_event_allowed_callbacks: 
     try: 
         res, replacement_data = await delay_cancellation( 
             callback(event, state_events) 
         ) 
     except CancelledError: 
         raise 
     except SynapseError as e: 
         # FIXME: Being able to throw SynapseErrors is relied upon by 
         # some modules. PR https://github.com/matrix-org/synapse/pull/10386 
         # accidentally broke this ability. 
         # That said, we aren't keen on exposing this implementation detail 
         # to modules and we should one day have a proper way to do what 
         # is wanted. 
         # This module callback needs a rework so that hacks such as 
         # this one are not necessary. 
         raise e 
     except Exception: 
         raise ModuleFailedException( 
             "Failed to run `check_event_allowed` module API callback" 
         ) 
         if not event.room_version.enforce_int_power_levels:
             keys = list(notification_levels.keys())
             for key in keys:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Fixed a bug that disturbed room creation when a check_event_allowed callback was registered by a module and power_level Notifications mapping exists.

		Contributed by @c-cal