send alerts - added debug logs

elementary-data · Nov 5, 2024 · 3d92557 · 3d92557
1 parent 9c66df0
commit 3d92557
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/elementary/clients/slack/client.py b/elementary/clients/slack/client.py
@@ -36,8 +36,10 @@ def create_client(
         if not config.has_slack:
             return None
         if config.slack_token:
+            logger.debug("Creating Slack client with token.")
             return SlackWebClient(token=config.slack_token, tracking=tracking)
         elif config.slack_webhook:
+            logger.debug("Creating Slack client with webhook.")
             return SlackWebhookClient(webhook=config.slack_webhook, tracking=tracking)
         return None
 

diff --git a/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py b/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py
@@ -1111,6 +1111,7 @@ def send_alert(
     ) -> bool:
         integration_params = self._get_integration_params(alert=alert)
         channel_name = integration_params.get("channel")
+        logger.debug(f"Sending alert to Slack channel: {channel_name}")
         try:
             self._fix_owners_and_subscribers(alert)
             template = self._get_alert_template(alert)
@@ -1156,18 +1157,15 @@ def _get_integration_params(
     ) -> Dict[str, Any]:
         integration_params = dict()
         if isinstance(self.client, SlackWebClient):
-            integration_params.update(
-                dict(
-                    channel=(
-                        self.config.slack_channel_name
-                        if self.override_config_defaults
-                        else (
-                            alert.unified_meta.get("channel")
-                            or self.config.slack_channel_name
-                        )
-                    )
-                )
-            )
+            if self.override_config_defaults:
+                channel = self.config.slack_channel_name
+                logger.debug(f"Using override config default channel: {channel}")
+            elif alert.unified_meta.get("channel"):
+                channel = alert.unified_meta.get("channel")
+                logger.debug(f"Using channel from meta: {channel}")
+            else:
+                channel = self.config.slack_channel_name
+            integration_params.update({"channel": channel})
         return integration_params
 
     def _create_single_alert_details_blocks(

diff --git a/elementary/monitor/data_monitoring/alerts/integrations/teams/teams.py b/elementary/monitor/data_monitoring/alerts/integrations/teams/teams.py
@@ -652,6 +652,7 @@ def send_alert(
         **kwargs,
     ) -> bool:
         try:
+            logger.debug("Sending alert via Teams.")
             self._get_alert_template(alert)
             sent_successfully = self.client.send_message()
         except Exception as e: