Add const for default group alerts threshold

elementary-data · Oct 14, 2024 · 5f1d7a7 · 5f1d7a7
1 parent 161330d
commit 5f1d7a7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/elementary/config/config.py b/elementary/config/config.py
@@ -35,6 +35,8 @@ class Config:
 
     DEFAULT_TARGET_PATH = os.getcwd() + "/edr_target"
 
+    DEFAULT_GROUP_ALERTS_THRESHOLD = 100
+
     def __init__(
         self,
         config_dir: str = DEFAULT_CONFIG_DIR,
@@ -128,7 +130,7 @@ def __init__(
         self.group_alerts_threshold = self._first_not_none(
             group_alerts_threshold,
             slack_config.get("group_alerts_threshold"),
-            100,
+            self.DEFAULT_GROUP_ALERTS_THRESHOLD,
         )
 
         teams_config = config.get(self._TEAMS, {})

diff --git a/elementary/monitor/cli.py b/elementary/monitor/cli.py
@@ -203,7 +203,7 @@ def get_cli_properties() -> dict:
 @click.option(
     "--group-alerts-threshold",
     type=int,
-    default=100,
+    default=Config.DEFAULT_GROUP_ALERTS_THRESHOLD,
     help="The threshold for all alerts in a single message.",
 )
 @click.option(

diff --git a/tests/mocks/data_monitoring/alerts/integrations/alerts_data_mock.py b/tests/mocks/data_monitoring/alerts/integrations/alerts_data_mock.py
@@ -1,4 +1,4 @@
-from elementary.monitor.alerts.grouped_alerts import GroupedByTableAlerts
+from elementary.monitor.alerts.alerts_groups import GroupedByTableAlerts
 from elementary.monitor.alerts.model_alert import ModelAlertModel
 from elementary.monitor.alerts.source_freshness_alert import SourceFreshnessAlertModel
 from elementary.monitor.alerts.test_alert import TestAlertModel

diff --git a/tests/mocks/data_monitoring/alerts/integrations/base_integration_mock.py b/tests/mocks/data_monitoring/alerts/integrations/base_integration_mock.py
@@ -1,7 +1,6 @@
 from typing import Union
 
-from elementary.monitor.alerts.grouped_alerts import GroupedByTableAlerts
-from elementary.monitor.alerts.grouped_alerts.grouped_alert import AlertsGroup
+from elementary.monitor.alerts.alerts_groups import AlertsGroup, GroupedByTableAlerts
 from elementary.monitor.alerts.model_alert import ModelAlertModel
 from elementary.monitor.alerts.source_freshness_alert import SourceFreshnessAlertModel
 from elementary.monitor.alerts.test_alert import TestAlertModel