Ele 3295 api dbt runner #1577
Merged
Ele 3295 api dbt runner #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @haritamar |
haritamar
force-pushed
the
ele-3295-api-dbt-runner
branch
from
e4fd3e8
to
970982b
Compare
haritamar
force-pushed
the
ele-3295-api-dbt-runner
branch
from
3f6e599
to
67a36e9
Compare
haritamar
commented
Jul 4, 2024
| quiet: bool, | ||
| log_output: bool, | ||
| log_format: str, | ||
| ) -> DbtCommandResult: |
There was a problem hiding this comment.
This was mostly taken from the exposures fork:
https://github.com/elementary-data/elementary-exposure-fork/blob/ele-1781-write-the-edr-exposures-command/elementary/clients/dbt/dbt_runner.py#L53
ofek1weiss
approved these changes
Jul 4, 2024
elementary/utils/env_vars_context.py
Outdated
| import os | ||
| from typing import Dict, Generator, Optional | ||
|
|
||
| from decorator import contextmanager |
There was a problem hiding this comment.
you can use contextlib.contextmanager instead, which is a builtin, and spare the new dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.