EventButton: Clean up drag n drop events#933
Merged
danirabbit merged 8 commits intomasterfrom Apr 10, 2026
Merged
Conversation
danirabbit
changed the title
jeremypw
approved these changes
Apr 10, 2026
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Looks good. Moving events between days and dropping onto e.g. Files works as before.
I note you cannot drop an event onto Code but that is also true for master. It would be possible to add a "text" target.
I also note that there is no drag icon but maybe that was always the case. It would be better if there were one but that can be left for another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some minor refactoring for DND. Uses a function instead of a lambda, sets selection data based on target type